Refs #29205 -- Added MultiValueField test for rendering of optional subfields.#14738
Merged
felixxm merged 1 commit intodjango:mainfrom Aug 10, 2021
Merged
Refs #29205 -- Added MultiValueField test for rendering of optional subfields.#14738felixxm merged 1 commit intodjango:mainfrom
felixxm merged 1 commit intodjango:mainfrom
Conversation
Member
carltongibson
left a comment
There was a problem hiding this comment.
Hey @smithdc1. Thanks for this. It's good — I think it's worth adding.
Can I ask you to pull it into a separate test case... test_multivalue_rendering or such, maybe simplifying PhoneField(🤔) ?
(As it is there's two screens — even on the portrait display — at least for my old-eyes 😀 — between the PhoneWidget/PhoneForm declaration and the output HTML, so it's tricky to see the expected values, without scrolling back and forth.)
felixxm
reviewed
Aug 4, 2021
felixxm
reviewed
Aug 4, 2021
fdf35be to
2bce0e6
Compare
2bce0e6 to
3a6431d
Compare
Member
|
@smithdc1 Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.