Fixed #29871 -- Allowed setting pk=None on a child model to create a copy.#12273
Merged
felixxm merged 1 commit intodjango:masterfrom Jan 15, 2020
Merged
Fixed #29871 -- Allowed setting pk=None on a child model to create a copy.#12273felixxm merged 1 commit intodjango:masterfrom
felixxm merged 1 commit intodjango:masterfrom
Conversation
ad0766f to
ae39115
Compare
Contributor
Author
|
I forgot to thank Tim for his work! |
felixxm
reviewed
Jan 13, 2020
Member
felixxm
left a comment
There was a problem hiding this comment.
@ChetanKhanna Thanks for this patch 👍 I left comments.
ae39115 to
6068d65
Compare
charettes
reviewed
Jan 14, 2020
Member
|
I added test without multi-models inheritance. |
a1b9bdf to
4fa96fe
Compare
Member
|
@ChetanKhanna Thanks for this patch 👍 Welcome aboard ⛵ @charettes Thanks for the review and initial patch 🌟 |
…copy. Thanks Simon Charette and Tim Graham for the initial patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensured that setting pk = None sets all parent_ptr_id's as well as
all AutoField's in the parent heirarchy to None. This follows the
current documentation on copying model instances:
https://docs.djangoproject.com/en/3.0/topics/db/queries/#copying-model-instances
Thanks Simon for the initial patches on Trac!