Fixed #30405 -- Fixed source code mismatch crash in ExceptionReporter. #11886
Merged
felixxm merged 2 commits intodjango:masterfrom Nov 12, 2019
Merged
Fixed #30405 -- Fixed source code mismatch crash in ExceptionReporter. #11886felixxm merged 2 commits intodjango:masterfrom
felixxm merged 2 commits intodjango:masterfrom
Conversation
apollo13
approved these changes
Nov 11, 2019
Member
|
@felixxm LGTM, there might still be cases where the lines are wrong, but at least this should prevent errors. |
9fef866 to
4b78546
Compare
Member
|
@apollo13 Thanks for the review ⭐ |
Contributor
|
👍, nice to see this merged. I was seeing the same issue with Jinja templates (using |
This was referenced Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket 30405