Skip to content

support tag delete via http request #933

Closed
ChenLingPeng wants to merge 5 commits intodistribution:masterfrom
ChenLingPeng:master
Closed

support tag delete via http request #933
ChenLingPeng wants to merge 5 commits intodistribution:masterfrom
ChenLingPeng:master

Conversation

@ChenLingPeng
Copy link
Copy Markdown

like 'curl -v -X "DELETE" http:///v2/library/helloworld/tag/v1'
it will delete tag library/helloworld:v1

@ChenLingPeng
Copy link
Copy Markdown
Author

It's my first PR here, could someone tell what should I do?
qq 20150827152031

@noxiouz
Copy link
Copy Markdown
Contributor

noxiouz commented Aug 27, 2015

@ChenLingPeng gofmt chekcs that a code format fits to the code style.
Please, run the gofmt -d -s . | grep -v Godeps/_workspace/src/ inside your fork to look at the diff, which fixes the style. And gofmt -s -w . | grep -v Godeps/_workspace/src/ to apply this fix to your code.

@ChenLingPeng
Copy link
Copy Markdown
Author

Thanks @noxiouz . Now it works!

…localhost:5000/v2/library/helloworld/tag/v1'

Signed-off-by: forrestchen <forrestchen@tencent.com>
Signed-off-by: forrestchen <forrestchen@tencent.com>
Signed-off-by: forrestchen <forrestchen@tencent.com>
Signed-off-by: forrestchen <forrestchen@tencent.com>
Signed-off-by: forrestchen <forrestchen@tencent.com>
@stevvooe
Copy link
Copy Markdown
Collaborator

From the specification:

For deletes, reference must be a digest or the delete will fail.

Because manifests have embedded the name and tag, deletions can only be done at the manifest level and only by digest. This is because, under concurrent load, the correct manifest to delete cannot be ascertained with certainty. The correct solution is to separate the tag from the manifest.

Please see #173 for a more complete proposal that would make tag deletion possible.

@stevvooe
Copy link
Copy Markdown
Collaborator

I don't feel this is the right approach to the API modifications. I'm closing this until we can get a proper proposal. Please use #174 and commentary from #62 as a template for how this should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants