registry/storage: add option to quiet GC output. #4560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c439a2 to
5c98929
Compare
milosgajdos
reviewed
Feb 2, 2025
Member
milosgajdos
left a comment
There was a problem hiding this comment.
This is incomplete. You need to pass the Quiet setting to GC somehow:
likely through
Line 45 in 7271d88
Consumers might not want GC output to be displayed (e.g, if you have your own logging system). Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
5c98929 to
a032989
Compare
Contributor
Author
|
Done: |
milosgajdos
reviewed
Feb 2, 2025
Member
milosgajdos
left a comment
There was a problem hiding this comment.
The code is fine now, but I think we should update the docs, too.
Sorry about not mentioning this on the previous review but would you mind mentioning the new cli switch in
Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
Contributor
Author
Good call. I've added |
milosgajdos
approved these changes
Feb 3, 2025
Member
milosgajdos
left a comment
There was a problem hiding this comment.
PTAL @thaJeztah @Jamstah @davidspek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumers might not want GC output to be displayed (e.g, if you have your own logging system).