Skip to content

Conversation

@ialidzhikov
Copy link
Contributor

Updating the github.com/distribution/distribution/v3 dependency from v3.0.0-alpha.1 to v3.0.0-beta.1 the module version of the corresponding project gets updated automatically: see https://github.com/gardener/gardener/pull/10105/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R3-R5

We want to use the x.y.0 format in the module version, see the motivation in gardener/gardener#9564.

Other projects like kubernetes and controller-runtime are using the same approach (the x.y.0 format as their module version).

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jul 29, 2024
@milosgajdos
Copy link
Member

Sign your commit, please.

Signed-off-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
@ialidzhikov
Copy link
Contributor Author

Sign your commit, please.

Done.

@milosgajdos
Copy link
Member

So, if I understand this correctly from the endless piles of docs about the toolchain, specifying 1.22.0 would pick the latest available toolchain compatible with 1.22.x Go release, right?

@milosgajdos milosgajdos requested a review from Jamstah August 6, 2024 09:37
Copy link
Collaborator

@Jamstah Jamstah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me.

@milosgajdos milosgajdos merged commit 2801004 into distribution:main Aug 6, 2024
@ialidzhikov ialidzhikov deleted the fix/module-version branch November 14, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants