fix nil pointer in s3 list api #4412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
milosgajdos
approved these changes
Jul 19, 2024
corhere
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4411
Ref: project-zot/zot#2532
On other situations, a nil check is present.
distribution/registry/storage/driver/s3-aws/s3.go
Line 760 in 2526198
There are still some missing nil checks, not sure
distribution/registry/storage/driver/s3-aws/s3.go
Line 740 in 2526198
distribution/registry/storage/driver/s3-aws/s3.go
Line 727 in 2526198
distribution/registry/storage/driver/s3-aws/s3.go
Line 794 in 2526198
distribution/registry/storage/driver/s3-aws/s3.go
Lines 778 to 779 in 2526198
distribution/registry/storage/driver/s3-aws/s3.go
Line 682 in 2526198