-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore: Migrate PR labeler config to v5 #4258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you sign your commit |
Signed-off-by: erezrokah <erezrokah@users.noreply.github.com>
310dcbf to
b1d1be8
Compare
Done |
milosgajdos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL @Jamstah
Jamstah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need **/*, ** will do it.
Co-authored-by: James Hewitt <james.hewitt@gmail.com> Signed-off-by: Erez Rokah <erezrokah@users.noreply.github.com>
Signed-off-by: Erez Rokah <erezrokah@users.noreply.github.com>
💯 Updated all the places I used |
Jamstah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
The PR labeler workflow uses v5 of the action but with a v4 configuration so it fails.
This should fix it (I think), see https://github.com/actions/labeler/tree/17086b774338d2689ada0d8fcc8c51b5c9bc782a#breaking-changes-in-v5