Do not close HTTP request body in HTTP handler #4067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Jamstah
approved these changes
Sep 22, 2023
thaJeztah
approved these changes
Sep 22, 2023
Member
thaJeztah
left a comment
There was a problem hiding this comment.
SGTM, but could use extra eyes as this always confuses me
corhere
approved these changes
Sep 22, 2023
Collaborator
corhere
left a comment
There was a problem hiding this comment.
The Go 1.21 go doc says:
// Body is the request's body.
//
// [...]
//
// For server requests, the Request Body is always non-nil
// but will return EOF immediately when no body is present.
// The Server will close the request body. The ServeHTTP
// Handler does not need to.LGTM!
dmcgowan
approved these changes
Sep 22, 2023
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4065