Adding first draft of CI on GitHub Actions #3338
Conversation
|
It would be great to get #3225 reviewed and merged in first before we merge this. |
|
@milosgajdos Yes I've discussed with @justincormack and @thaJeztah about that and I agree we can first of all put the current CI back in order similar to what was done with travis (make, etc...) and later show the enhancements provided by buildx/bake to be platform agnostic and make a proposal around that with #3315. |
@milosgajdos currently we have no CI running (travis no longer runs after the repository was moved), so probably better to have this one in first.
Yes, let's get CI at least running again; improvements can be made after that (thanks for #3315 though! ❤️) |
|
Looks like probot is already running, and it's working, because it found that the last commit misses a DCO sign off 😅 https://github.com/distribution/distribution/pull/3338/checks?check_run_id=1793278086 |
|
So we could probably skip the DCO check in the other action (perhaps you can squash the commits as well 🤗) |
Codecov Report
@@ Coverage Diff @@
## main #3338 +/- ##
=======================================
Coverage 56.12% 56.12%
=======================================
Files 105 105
Lines 7431 7431
=======================================
Hits 4171 4171
Misses 2615 2615
Partials 645 645
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
The script seems to check for other things as well so I think it is worth keeping every thing seems to be fixed now. |
| - uses: actions/checkout@v2 | ||
| with: | ||
| path: src/github.com/docker/distribution | ||
| fetch-depth: 50 |
There was a problem hiding this comment.
@chrispat I think this line is the issue causing DCO script to fail
There was a problem hiding this comment.
Not it was because git-validation has special handling for Travis https://github.com/vbatts/git-validation/blob/60cb8713913d4fa6c2ca20844a89376c37bd3d35/main.go#L69. I fixed it by passing in the commit range explicitly.
Signed-off-by: Chris Patterson <chrispat@github.com>
|
Ok I think we have an equivalent CI running on Actions to what was in Travis. Someone drop a 👍 if you think we are good to merge. |
Starting conversion from TravisCI to GitHub Actions for CI
Signed-off-by: Chris Patterson chrispat@github.com