-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix CI failures, upgrade to Go 1.14+ #3187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Modify Travis manifest to use Go 1.14.x - Hardcode version of golangci-lint in setup script - Hardcode version of go-md2man in setup script Signed-off-by: jdolitsky <393494+jdolitsky@users.noreply.github.com>
|
@thaJeztah regarding your comments-
The remainder of the script is just Regarding why the I figured this same logic applies to go-md2man as well. If you think we should instead use golanglint-ci's recommended installation procedure (curl to bash), I'm happy to make just that modification. Additionally, the latest version of golangci-lint (v1.27.0) appears to require Go 1.14, so this was upgraded as well. Let me know if you prefer any changes after this explanantion. |
Oh! I see I commented before oyu made the final changes, yes, makes sense
Ah, gotcha, thanks! |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping @manishtomar @dmcgowan PTAL
manishtomar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.