Skip to content

Add configuration option for Redis TLS #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaodrp merged 1 commit into from
Apr 23, 2021
Merged

Add configuration option for Redis TLS #3161

joaodrp merged 1 commit into from
Apr 23, 2021

Conversation

@jdolitsky
Copy link
Contributor

@jdolitsky jdolitsky commented May 13, 2020

Resolves #3160

jdolitsky
jdolitsky commented May 13, 2020
View reviewed changes
@jdolitsky jdolitsky mentioned this pull request Jun 26, 2020
Merged
@bbobrov bbobrov mentioned this pull request Oct 8, 2020
Closed
Base automatically changed from master to main January 27, 2021 15:51
@milosgajdos
Copy link
Member

milosgajdos commented Mar 1, 2021

This needs rebasing.

@jdolitsky
Add configuration option for Redis TLS
32ccbf1 
Signed-off-by: Josh Dolitsky <josh@dolit.ski>
@codecov-io
Copy link

codecov-io commented Mar 2, 2021

Codecov Report

Merging #3161 (32ccbf1) into main (90e62ac) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3161      +/-   ##
==========================================
- Coverage   56.24%   56.23%   -0.01%     
==========================================
  Files         102      102              
  Lines        7227     7228       +1     
==========================================
  Hits         4065     4065              
- Misses       2520     2521       +1     
  Partials      642      642
Impacted Files Coverage Δ
...distribution/distribution/registry/handlers/app.go 46.16% <0.00%> (-0.09%) ⬇️
...bution/distribution/configuration/configuration.go 62.03% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e62ac...32ccbf1. Read the comment docs.

@jdolitsky
Copy link
Contributor Author

jdolitsky commented Mar 2, 2021

@milosgajdos - done!

@milosgajdos milosgajdos requested a review from wy65701436 March 2, 2021 10:00
@milosgajdos milosgajdos requested a review from joaodrp April 23, 2021 15:06
@joaodrp joaodrp merged commit a27b0c4 into distribution:main Apr 23, 2021
@MinerYang MinerYang mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaodrp joaodrp joaodrp approved these changes

@milosgajdos milosgajdos milosgajdos approved these changes

@wy65701436 wy65701436 Awaiting requested review from wy65701436

Assignees

No one assigned

Labels

enhancement security status/1-design-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Redis TLS

4 participants

@jdolitsky @milosgajdos @codecov-io @joaodrp