Skip to content

default autoredirect to false #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Jan 7, 2019
Merged

default autoredirect to false #2800

dmcgowan merged 1 commit into from
Jan 7, 2019

Conversation

@davidswu
Copy link
Contributor

@davidswu davidswu commented Jan 4, 2019 •
edited
Loading

closes #2799

@GordonTheTurtle
Copy link

GordonTheTurtle commented Jan 4, 2019

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "autoredirect" git@github.com:davidswu/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

default autoredirect to false
eb1a2cd 
Signed-off-by: David Wu <david.wu@docker.com>
@davidswu davidswu requested review from caervs and dmcgowan January 4, 2019 19:10
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #2800 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2800      +/-   ##
==========================================
+ Coverage   60.24%   60.25%   +<.01%     
==========================================
  Files         103      103              
  Lines        8022     8024       +2     
==========================================
+ Hits         4833     4835       +2     
  Misses       2546     2546              
  Partials      643      643
Flag Coverage Δ
#linux 60.25% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
registry/auth/token/accesscontroller.go 66.16% <66.66%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b7b58...eb1a2cd. Read the comment docs.

caervs
caervs approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Jan 4, 2019
Closed
Merged
Open
@davidswu davidswu requested a review from dmp42 January 4, 2019 21:44
@davidswu davidswu mentioned this pull request Jan 4, 2019
Merged
dmp42
dmp42 approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@dmp42 dmp42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caervs caervs mentioned this pull request Jan 7, 2019
Merged
@dmcgowan
Copy link
Collaborator

dmcgowan commented Jan 7, 2019

LGTM

@dmcgowan dmcgowan merged commit 980d1a6 into distribution:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

2 more reviewers

@dmp42 dmp42 dmp42 approved these changes

@caervs caervs caervs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2.7.0 violates semver

5 participants

@davidswu @GordonTheTurtle @dmcgowan @dmp42 @caervs