Skip to content

API to retrieve lists of manifest descriptors#2199

Closed
sergeyfd wants to merge 7 commits intodistribution:masterfrom
sergeyfd:dglist
Closed

API to retrieve lists of manifest descriptors#2199
sergeyfd wants to merge 7 commits intodistribution:masterfrom
sergeyfd:dglist

Conversation

@sergeyfd
Copy link
Copy Markdown
Contributor

@sergeyfd sergeyfd commented Feb 25, 2017 •
edited
Loading

API to retrieve manifests lists

Signed-off-by: Serge Dubrouski sergeyfd@gmail.com

@sergeyfd
Copy link
Copy Markdown
Contributor Author

sergeyfd commented Feb 25, 2017

This is a first and definitely unfinished iteration for implementation of item 3 from #2170. New endpoint /v2/<name>/manifests/ returns a list of descriptors for all images in the named repository. More tests need to be added as well as support for pagination and changes in the specification. But let's start a discussion on the main design first.

@sergeyfd sergeyfd mentioned this pull request Feb 25, 2017
Closed
3 tasks
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 25, 2017 •
edited by codecov bot
Loading

Codecov Report

Merging #2199 into master will decrease coverage by 10.21%.
The diff coverage is 35.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2199       +/-   ##
===========================================
- Coverage    60.8%   50.59%   -10.22%     
===========================================
  Files         129      126        -3     
  Lines       11901    14568     +2667     
===========================================
+ Hits         7236     7370      +134     
- Misses       3764     6440     +2676     
+ Partials      901      758      -143
Impacted Files Coverage Δ
registry/api/v2/descriptors.go 100% <ø> (ø) ⬆️
registry/api/v2/routes.go 100% <ø> (ø) ⬆️
manifests.go 68.96% <ø> (-4.95%) ⬇️
registry/handlers/manifests.go 50.12% <0%> (-5.15%) ⬇️
registry/handlers/app.go 48.38% <100%> (+0.67%) ⬆️
registry/storage/manifeststore.go 64.7% <38.29%> (-16.66%) ⬇️
registry/client/repository.go 55.74% <47.05%> (-3.76%) ⬇️
registry/api/v2/urls.go 76.78% <62.5%> (-1.55%) ⬇️
registry/proxy/proxymanifeststore.go 60.34% <87.5%> (-1.2%) ⬇️
registry/storage/driver/gcs/gcs.go 0.32% <0%> (-68.74%) ⬇️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749f6af...70f3056. Read the comment docs.

@sergeyfd
Copy link
Copy Markdown
Contributor Author

sergeyfd commented Mar 6, 2017

@stevvooe Could you take a look?

@stevvooe
Copy link
Copy Markdown
Collaborator

stevvooe commented Mar 6, 2017

@sergeyfd Is there an update to the specification that describes the changes?

@sergeyfd
Copy link
Copy Markdown
Contributor Author

sergeyfd commented Mar 6, 2017

@stevvooe No, not yet because I am not sure if this is what we really want. The main idea is that it returns list of manifest descriptors when called through /v2/<name>/manifests/. Returning json looks somewhat like this:

"name": "test/t1",
	"descriptors": [
		{"mediaType":"application/vnd.docker.distribution.manifest.v2+json",
		 "size":2805,
		 digest":"sha256:899bedd554faf1716d36b310199edae72f348abc8d52ac562cb28cc7998d05e1"},
		{"mediaType":"application/vnd.docker.distribution.manifest.v1+prettyjws",
		 "size":3308,
		 "digest":"sha256:86942f70cd992d0d33d6db048444bc7bb98718c0807a615212346ffada92157f"},
		{"mediaType":"application/vnd.docker.distribution.manifest.v2+json",
		 "size":1768,
		 "digest":"sha256:a27bac78eeee243ce14684870190ad46cefa817bdc046c692a5aed029b5aebf1"}	
	]

@jonjohnsonjr jonjohnsonjr mentioned this pull request Sep 15, 2017
Open
@Vanuan Vanuan mentioned this pull request Sep 15, 2017
Open
@Vanuan Vanuan mentioned this pull request Oct 10, 2017
Closed
@sergeyfd
Copy link
Copy Markdown
Contributor Author

sergeyfd commented Nov 2, 2017

I updated specifications. @stevvooe is there a time line for 2.7 release?

@stevvooe stevvooe mentioned this pull request Jan 23, 2018
Merged
@jonjohnsonjr jonjohnsonjr mentioned this pull request Jun 4, 2018
Open
zhouhaibing089 and others added 7 commits July 1, 2018 16:52
@zhouhaibing089 @sergeyfd
cmd/digest: import crypto algorithms
2b980e9 
the digest cli does not work if we do not import this two packages,
tested in go1.9. basically, we have to make several algorithms to
be available by calling crypto.RegisterHash in init functions.

Signed-off-by: zhouhaibing089 <zhouhaibing089@gmail.com>
@sergeyfd
API to retrieve manifest lists
5bd1524 
Signed-off-by: Serge Dubrouski <sergeyfd@gmail.com>

API to retrieve digests lists

Signed-off-by: Serge Dubrouski <sergeyfd@gmail.com>

API to retrieve manifests lists

Signed-off-by: Serge Dubrouski <sergeyfd@gmail.com>
@sergeyfd
API to retrieve digests lists
8918d54 
Signed-off-by: Serge Dubrouski <sergeyfd@gmail.com>
@sergeyfd
API to retrieve digests lists
2859d95 
Signed-off-by: Serge Dubrouski <sergeyfd@gmail.com>
@sergeyfd
API to retrieve digests lists
a312793 
Signed-off-by: Serge Dubrouski <sergeyfd@gmail.com>
@sergeyfd
API to retrieve digests lists
0984c4a 
Signed-off-by: Serge Dubrouski <sergeyfd@gmail.com>
@sergeyfd
API to retrieve digests lists
70f3056 
Signed-off-by: Serge Dubrouski <sergeyfd@gmail.com>
@jonjohnsonjr jonjohnsonjr mentioned this pull request Aug 29, 2018
Closed
@dmcgowan
Copy link
Copy Markdown
Collaborator

dmcgowan commented Feb 23, 2020

Additions to specifications are no longer being considered here. The specification has moved to https://github.com/opencontainers/distribution-spec

@dmcgowan dmcgowan closed this Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sergeyfd @codecov-io @stevvooe @dmcgowan @zhouhaibing089