spec/manifest: clarify relationship between urls and foreign layers#1932
Merged
aaronlehmann merged 1 commit intodistribution:masterfrom Aug 30, 2016
Merged
spec/manifest: clarify relationship between urls and foreign layers#1932aaronlehmann merged 1 commit intodistribution:masterfrom
aaronlehmann merged 1 commit intodistribution:masterfrom
Conversation
Collaborator
|
LGTM |
Current coverage is 51.29% (diff: 100%)@@ master #1932 diff @@
==========================================
Files 123 123
Lines 10936 10936
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6732 5610 -1122
- Misses 3324 4584 +1260
+ Partials 880 742 -138
|
docs/spec/manifest-v2-2.md
Outdated
| contains a non-empty list of URLs from which this object can be | ||
| downloaded. | ||
| Provides a list of URLs from which the content may be fetched. Content | ||
| should be verified against the `digest` and `size`. |
There was a problem hiding this comment.
Should this point out that urls is optional and will generally be absent?
Previously, the specificiation incorrectly bound the fates of `urls` and foreign layers. These are complementary but unrelated features, in that the `urls` field may be populated for layers that aren't foreign. The type of the layer only dictates the push behavior of the layer, rather than involving where it came from. For example, one may pull a foreign layer from a registry, but they may not push it back to another registry. Conversely, a layer that has no restrictions on push/pull behavior may be fetched via `urls` entries. Signed-off-by: Stephen J Day <stephen.day@docker.com>
a00a226 to
6bcdb38
Compare
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the specificiation incorrectly bound the fates of
urlsandforeign layers. These are complementary but unrelated features, in that
the
urlsfield may be populated for layers that aren't foreign. Thetype of the layer only dictates the push behavior of the layer, rather
than involving where it came from.
For example, one may pull a foreign layer from a registry, but they may
not push it back to another registry. Conversely, a layer that has no
restrictions on push/pull behavior may be fetched via
urlsentries.Signed-off-by: Stephen J Day stephen.day@docker.com
Closes #1931