Improve consistence to delete manifest#1137
Closed
xiekeyang wants to merge 1 commit intodistribution:masterfrom
xiekeyang:del-tag
Closed
Improve consistence to delete manifest#1137xiekeyang wants to merge 1 commit intodistribution:masterfrom xiekeyang:del-tag
xiekeyang wants to merge 1 commit intodistribution:masterfrom
xiekeyang:del-tag
Conversation
This PR is only for resolving consistence, to delete revision and tag blob links. Signed-off-by: xiekeyang <xiekeyang@huawei.com>
Collaborator
|
This actually makes deletion less consistent. It takes the deletion of one item and replaces it with 4 round trips to the backend, any of which can fail. It then tests for existence, making the decision to delete something, without holding any lock to ensure that item still exists. Even more so, it then deletes the tag from the tag store, which may reference other manifests, corrupting the data store. This PR actually makes it less consistent, racy and corrupts the data backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, deleting manifest uses
manifestStore.Deletefunction.However, it only delete revision link, and its tag blob link files still exist.
It leads problem that user can still view the deleted tag in tags list.
I think tag blob links should be deleted consistently. We can add
tagStore.deletetomanifestStore.Deleteto do it.This PR is only for resolving a consistence, and there are still improvement need to do for soft deleting.
Signed-off-by: xiekeyang xiekeyang@huawei.com