DEV: Bump aws-sdk-core in prep for aws-sdk-mediaconvert#33250
Merged
blake-discourse merged 5 commits intomainfrom Jun 20, 2025
Merged
DEV: Bump aws-sdk-core in prep for aws-sdk-mediaconvert#33250blake-discourse merged 5 commits intomainfrom
blake-discourse merged 5 commits intomainfrom
Conversation
In an upcoming pr #33092 that adds support for aws-sdk-mediaconvert it requires that we bump aws-sdk-core to 3.225.0 ``` + aws-sdk-mediaconvert (1.160.0) + aws-sdk-core (~> 3, >= 3.225.0) ``` but in doing so there are apparently some api changes and it requires changes in core to support the new version. I thought it would best to break out these changes in a separate PR as to not muddy up the mediaconvert pr that is already quite large.
72ff987 to
0064735
Compare
…ut throwing an ArgumentError. The is a standard response for S3 delete operations.
…t we don't get this error:
…array. This fixes the ArgumentError: expected params to be a hash, got class Array instead.
cvx
approved these changes
Jun 20, 2025
This was referenced Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an upcoming pr #33092 that adds support for aws-sdk-mediaconvert it requires
that we bump aws-sdk-core to 3.225.0
but in doing so there are apparently some api changes and it requires changes
in core to support the new version. I thought it would best to break out these
changes in a separate PR as to not muddy up the mediaconvert pr that is already
quite large.