DEV: introduce Ember <template> tag support (.gjs)#22719
Merged
davidtaylorhq merged 13 commits intomainfrom Jul 20, 2023
Merged
DEV: introduce Ember <template> tag support (.gjs)#22719davidtaylorhq merged 13 commits intomainfrom
<template> tag support (.gjs)#22719davidtaylorhq merged 13 commits intomainfrom
Conversation
This enables support for .gjs files in the build Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com>
* Add missing `truth-helpers` dependencies This addon is in the workspace but not explicitly referenced in package.json (should it be in devDependencies?) * Export helpers from `d-icon` in discourse-common In order to use helpers in `<template>` they need to be imported. Not sure what's the semantics of the `registerUnbound` internal helper and if this refactor changed anything important. Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com>
This tells GitHub to use js/ts mode for gjs/gts syntax highlighting, which is hopefully better than nothing? Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com>
Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com>
This adds Glint to the project in JS mode (as opposed to TS). This brings back the basic JS language server support in .gjs files in VSCode (if you have the Glint extension installed). For other editors, it should be possible to integrate directly via the `glint-language-server` executable. Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com>
Change the sample vscode settings: extensions.json – this "recommends" the appropriate VSCode extensions for use with .gjs development settings.json – this sets the default formatter for .gjs files (without this setting the user will be prompted to select one the first time), also sets up the ESLint extension to check .gjs files. Note that – the .vscode-sample directory doesn't do anything by itself. These changes need to be pulled into your local `.vscode` directory. Added the `.vscode` directory to `.gitignore` for now, but feel free to improve on that setup. Co-authored-by: Krystan HuffMenne <kmenne+github@gmail.com>
cvx
reviewed
Jul 20, 2023
| export function renderIcon(renderType, id, params) { | ||
| params ||= {}; | ||
|
|
||
| export function renderIcon(renderType, id, options = {}) { |
Contributor
There was a problem hiding this comment.
Are we 100% sure this is safe change? 😃 There might be a null value passed in, e.g. by some theme component?
Member
Author
There was a problem hiding this comment.
Reverted that diff
cvx
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relands #21899 rebased onto latest
main, and with plugin support