Skip to content

[Fix] Modal Write invocation without instance and missing ChannelTypes#3221

Merged
Misha-133 merged 18 commits into
discord-net:devfrom
Cenngo:fix/modal-write-invocation
Jan 22, 2026
Merged

[Fix] Modal Write invocation without instance and missing ChannelTypes#3221
Misha-133 merged 18 commits into
discord-net:devfrom
Cenngo:fix/modal-write-invocation

Conversation

@Cenngo

@Cenngo Cenngo commented Jan 3, 2026

Copy link
Copy Markdown
Collaborator
  • Fixes the modal building logic to run ModalComponentTypeConverter.WriteAsync() even when no modal instance is provided.
  • Adds the missing channelTypes property to the ChannelSelect builder and info classes.
  • Removes the public setter requirement from modal component properties and adds enforcement to only the input components
  • Added channel type constraint mapping from property type to single channel select
  • Misc refactors for code brevity
  • Added Id parameters to modal components

@Cenngo Cenngo requested a review from Misha-133 January 5, 2026 20:27
@Cenngo Cenngo marked this pull request as ready for review January 5, 2026 20:27
@Cenngo Cenngo requested a review from Misha-133 January 22, 2026 13:16
@Misha-133 Misha-133 merged commit 9c1db3f into discord-net:dev Jan 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants