Make Cacheable constructors public#3177
Merged
Merged
Conversation
Misha-133
approved these changes
Aug 30, 2025
Misha-133
left a comment
Member
There was a problem hiding this comment.
I don't see a reason for it to be internal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simply makes the constructors for the 2 different Cacheable structs public.
I want to use this mechanism in my bot's code without duplicating the class in my own project but obviously I can if this functionality is not desired.
I did not add an XML doc, however I can add one if that is desired.
Changes
internalconstructor forCacheable<TCachedEntity, TDownloadableEntity, TRelationship, TId>madepublicinternalconstructor forCacheable<TEntity, TId>madepublicRelated Issues
N/A