fix(IsLoadableModule): return false for abstract classes#3148
Merged
Misha-133 merged 4 commits intoJul 13, 2025
Merged
Conversation
IsLoadableModule did not check the property TypeInfo.IsAbstract. Therefore, an unnecessary warning log stated that it could not be loaded. Now, if a class is abstract, it will be ignored safely and all the inheritors will continue to load any commands.
Cenngo
requested changes
Jun 26, 2025
Co-authored-by: Cenk Ergen <57065323+Cenngo@users.noreply.github.com>
Contributor
Author
|
@Cenngo your suggestion looks completely fine - I have:
Hold on, we might be missing some. Screenshot of the
Should I include Also, it may help to sort the |
Collaborator
That wouldnt be necessary since both of those already inherit the |
Cenngo
approved these changes
Jul 1, 2025
Contributor
Author
|
Perfect, PR is now ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IsLoadableModuledid not check the propertyTypeInfo.IsAbstract. Therefore, an unnecessary warning log stated that it could not be loaded.Now, if a class is abstract, it will be ignored safely and all the inheritors will continue to load any commands.
Changes
Related Issues
N/A