Skip to content

Update shell_elvish.go to the newer (non-deprecated) Elvish syntax#896

Merged
zimbatm merged 2 commits intodirenv:masterfrom
icidasset:patch-1
Apr 21, 2022
Merged

Update shell_elvish.go to the newer (non-deprecated) Elvish syntax#896
zimbatm merged 2 commits intodirenv:masterfrom
icidasset:patch-1

Conversation

@icidasset
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

@mmlb mmlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zimbatm this lgtm as an elvish user.

@zimbatm
Copy link
Copy Markdown
Member

zimbatm commented Mar 27, 2022

@icidasset do you mind rebasing? I'm not sure why the CI didn't run.

@icidasset
Copy link
Copy Markdown
Contributor Author

@icidasset do you mind rebasing? I'm not sure why the CI didn't run.

Done 👀

@zimbatm zimbatm merged commit e5a6e4c into direnv:master Apr 21, 2022
@zimbatm
Copy link
Copy Markdown
Member

zimbatm commented Apr 21, 2022

thanks!

@zimbatm zimbatm mentioned this pull request Apr 21, 2022
@avioli
Copy link
Copy Markdown

avioli commented May 25, 2022

Since 0.18.0 - syntax should be try {} catch e {}, not try {} except e {}, since except is now deprecated and will be removed from 0.19.0

@zimbatm
Copy link
Copy Markdown
Member

zimbatm commented May 25, 2022

Do you mind sending a PR? I will do a release afterwards. you already did!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants