Allow optional leading v in .node-version file#833
Closed
shadowspawn wants to merge 2 commits intodirenv:masterfrom
Closed
Allow optional leading v in .node-version file#833shadowspawn wants to merge 2 commits intodirenv:masterfrom
shadowspawn wants to merge 2 commits intodirenv:masterfrom
Conversation
Author
|
On a related note. If you are interested, I could also suggest changes to allow a Windows EOL in This is how I did it for |
Author
|
Happy to try and help if interested in future. |
Member
|
sorry I didn't get back to you. I want to move language-specific helpers out of the stdlib as they cause most of the release churn and are best maintained by language experts. I always feel uncomfortable changing them as I don't know if it will break back-compat or not. Instead of that, I propose:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small suggested feature for convenience of users and greater compatibility with other products using
.node-version. Feel free to reject!Related use cases:
vwhen displaying its version. This might be written into a version control file:.node-versionfile allow a leadingvon the version.nvmsupports leadingvon version when used directly, and thevis included in the example here: https://github.com/direnv/direnv/wiki/NodeExample file:
Before fix:
After fix:
Paranoia: This could break users who are specifying a
vwhich is part of the path to the node on disk with their setup. The work-around for the user would be to add thevintoNODE_VERSION_PREFIX.