Make direnv hook output work on Windows#632
Merged
zimbatm merged 1 commit intodirenv:masterfrom May 8, 2020
Merged
Conversation
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, you have to write your own
_direnv_hookto run on Cygwin or msys/git bash, because the backslashes are currently interpreted as escapes within the string, rather than actual characters.(Technically, all the Hook functions should be escaping
.SelfPathin their templates, but that's a much bigger change since most of the shell implementations don't have an escape method, and doing the escaping internal to the Hook method means changing a lot of files.)