Patch Tuesday 🐸 by paescuj · Pull Request #18643 · directus/directus

paescuj · 2023-05-17T23:26:19Z

`directus-monorepo`

 @typescript-eslint/eslint-plugin  5.59.0  →  5.59.6
 @typescript-eslint/parser         5.59.0  →  5.59.6
 eslint                            8.38.0  →  8.40.0
 eslint-plugin-vue                 9.12.0  →  9.13.0
 prettier                           2.8.7  →   2.8.8

`@directus/api`

 @aws-sdk/client-ses                3.316.0  →  3.332.0
 @keyv/redis                          2.5.7  →    2.5.8
 @types/async                        3.2.19  →   3.2.20
 @types/express-serve-static-core   4.17.33  →  4.17.35
 @types/jsonwebtoken                  9.0.1  →    9.0.2
 @types/marked                        4.0.8  →    4.3.0
 @types/node                       18.15.13  → 18.16.12
 @vitest/coverage-c8                 0.31.0  →   0.31.1
 axios                                1.3.6  →    1.4.0
 date-fns                            2.29.3  →   2.30.0
 fast-redact                          3.1.2  →    3.2.0
 helmet                               6.1.5  →    7.0.0
 inquirer                             9.1.5  →    9.2.4
 joi                                 17.9.1  →   17.9.2
 ldapjs                               2.2.3  →    2.3.3
 liquidjs                            10.7.0  →   10.7.1
 marked                               4.3.0  →    5.0.2
 nodemailer                           6.9.1  →    6.9.2
 openid-client                        5.4.0  →    5.4.2
 ora                                  6.3.0  →    6.3.1
 pg                                  8.10.0  →   8.11.0
 pino                                8.11.0  →   8.14.1
 qs                                  6.11.1  →   6.11.2
 rollup                              3.20.7  →   3.22.0
 sharp                               0.32.0  →   0.32.1
 tedious                             16.0.0  →   16.1.0
 tsx                                 3.12.6  →   3.12.7
 vitest                              0.31.0  →   0.31.1
 vm2                                 3.9.18  →   3.9.19

❌ Can't be updated at this time

ldapjs 2 → 3 Bigger change, requires separate PR
openapi3-ts 3 → 4 Bigger change, requires separate PR
@types/node 18 → 20 We're currently targeting Node.js v18

`@directus/app`

 @babel/core                     7.21.4  →  7.21.8
 @babel/preset-env               7.21.4  →  7.21.5
 @editorjs/editorjs              2.26.5  →  2.27.0
 @fullcalendar/core               6.1.5  →   6.1.7
 @fullcalendar/daygrid            6.1.5  →   6.1.7
 @fullcalendar/interaction        6.1.5  →   6.1.7
 @fullcalendar/list               6.1.5  →   6.1.7
 @fullcalendar/timegrid           6.1.5  →   6.1.7
 @pinia/testing                   0.1.0  →   0.1.1
 @rollup/plugin-yaml              4.0.1  →   4.1.0
 @storybook/addon-actions         7.0.6  →  7.0.12
 @storybook/addon-backgrounds     7.0.6  →  7.0.12
 @storybook/addon-docs            7.0.6  →  7.0.12
 @storybook/addon-essentials      7.0.6  →  7.0.12
 @storybook/addon-links           7.0.6  →  7.0.12
 @storybook/addon-mdx-gfm         7.0.6  →  7.0.12
 @storybook/addon-measure         7.0.6  →  7.0.12
 @storybook/addon-outline         7.0.6  →  7.0.12
 @storybook/client-api            7.0.6  →  7.0.12
 @storybook/client-logger         7.0.6  →  7.0.12
 @storybook/vue3                  7.0.6  →  7.0.12
 @storybook/vue3-vite             7.0.6  →  7.0.12
 @types/mapbox__mapbox-gl-draw    1.3.3  →   1.4.0
 @types/marked                    4.0.8  →   4.3.0
 apexcharts                      3.39.0  →  3.40.0
 axios                            1.3.6  →   1.4.0
 codemirror                     5.65.12  → 5.65.13
 date-fns                        2.29.3  →  2.30.0
 dompurify                        3.0.2  →   3.0.3
 happy-dom                        9.8.4  →  9.18.3
 marked                           4.3.0  →   5.0.2
 pinia                           2.0.36  →   2.1.1
 qrcode                           1.5.1  →   1.5.3
 sass                            1.62.0  →  1.62.1
 storybook                        7.0.6  →  7.0.12
 tinymce                          6.4.1  →   6.4.2
 vite                             4.3.1  →   4.3.7
 vitest                          0.31.0  →  0.31.1
 webpack                         5.80.0  →  5.83.1

codemirror 5 → 6 Looks like codemirror 6 is a total rewrite and restructure of codemirror, meaning that the migration path is effectively the same as replacing codemirror completely. This should be done as a separate effort.
mapbox-gl 1 → 2 Map interface/layout cannot be rendered after adding Mapbox Access Token in Project Settings #16185
maplibre-gl 1 → 2 Map interface/layout cannot be rendered after adding Mapbox Access Token in Project Settings #16185

`@directus/composables`

 @vitest/coverage-c8  0.31.0  →  0.31.1
 axios                 1.3.6  →   1.4.0
 vitest               0.31.0  →  0.31.1

`create-directus-extension`

 inquirer  9.1.5  →  9.2.4

`@directus/data`

 @types/node          18.15.13  →  18.16.12
 @vitest/coverage-c8    0.31.0  →    0.31.1
 vitest                 0.31.0  →    0.31.1

❌ Can't be updated at this time

@types/node 18 → 20 We're currently targeting Node.js v18

`@directus/data-driver-postgres`

 @types/node          18.15.13  →  18.16.12
 @vitest/coverage-c8    0.31.0  →    0.31.1
 vitest                 0.31.0  →    0.31.1

❌ Can't be updated at this time

@types/node 18 → 20 We're currently targeting Node.js v18

`@directus/exceptions`

 @vitest/coverage-c8  0.31.0  →  0.31.1
 joi                  17.9.1  →  17.9.2
 vitest               0.31.0  →  0.31.1

`@directus/extensions-sdk`

 @rollup/plugin-commonjs   24.1.0  →   25.0.0
 @rollup/plugin-terser      0.4.1  →    0.4.3
 @vitest/coverage-c8       0.31.0  →   0.31.1
 esbuild                  0.17.17  →  0.17.19
 inquirer                   9.1.5  →    9.2.4
 ora                        6.3.0  →    6.3.1
 rollup                    3.20.7  →   3.22.0
 vite                       4.3.1  →    4.3.7
 vitest                    0.31.0  →   0.31.1

`@directus/pressure`

 @vitest/coverage-c8  0.31.0  →  0.31.1
 vitest               0.31.0  →  0.31.1

`@directus/random`

 @vitest/coverage-c8  0.31.0  →  0.31.1
 vitest               0.31.0  →  0.31.1

`@directus/release-notes-generator`

 @pnpm/find-workspace-packages     6.0.7  →     6.0.8
 @types/node                    18.15.13  →  18.16.12
 @vitest/coverage-c8              0.31.0  →    0.31.1
 vitest                           0.31.0  →    0.31.1

❌ Can't be updated at this time

@types/node 18 → 20 We're currently targeting Node.js v18

`@directus/specs`

❌ Can't be updated at this time

openapi3-ts 3 → 4 Bigger change, requires separate PR

`@directus/storage`

 @types/node          18.15.13  →  18.16.12
 @vitest/coverage-c8    0.31.0  →    0.31.1
 vitest                 0.31.0  →    0.31.1

❌ Can't be updated at this time

@types/node 18 → 20 We're currently targeting Node.js v18

`@directus/storage-driver-azure`

 @vitest/coverage-c8  0.31.0  →  0.31.1
 vitest               0.31.0  →  0.31.1

`@directus/storage-driver-cloudinary`

 @vitest/coverage-c8  0.31.0  →  0.31.1
 undici               5.22.0  →  5.22.1
 vitest               0.31.0  →  0.31.1

`@directus/storage-driver-gcs`

 @google-cloud/storage   6.9.5  →  6.10.1
 @vitest/coverage-c8    0.31.0  →  0.31.1
 vitest                 0.31.0  →  0.31.1

`@directus/storage-driver-local`

 @vitest/coverage-c8  0.31.0  →  0.31.1
 vitest               0.31.0  →  0.31.1

`@directus/storage-driver-s3`

 @aws-sdk/abort-controller  3.310.0  →  3.329.0
 @aws-sdk/client-s3         3.317.0  →  3.332.0
 @aws-sdk/lib-storage       3.317.0  →  3.332.0
 @vitest/coverage-c8         0.31.0  →   0.31.1
 vitest                      0.31.0  →   0.31.1

`@directus/types`

 pino  8.11.0  →  8.14.1

`@directus/update-check`

 @types/semver        7.3.13  →   7.5.0
 @vitest/coverage-c8  0.31.0  →  0.31.1
 semver                7.5.0  →   7.5.1
 undici               5.22.0  →  5.22.1
 vitest               0.31.0  →  0.31.1

`@directus/utils`

 @types/node          18.15.13  →  18.16.12
 @vitest/coverage-c8    0.31.0  →    0.31.1
 date-fns               2.29.3  →    2.30.0
 joi                    17.9.1  →    17.9.2
 vitest                 0.31.0  →    0.31.1

`docs`

 vitepress  1.0.0-alpha.73  →  1.0.0-alpha.75

`tests-blackbox`

 autocannon  7.10.0  →  7.11.0
 axios        1.3.6  →   1.4.0
 listr2       6.3.1  →   6.6.0

❌ Can't be updated at this time

globby 11 → 13 ESM only

Misc

Bump build-push-action in release workflow to v4
Bump pnpm to 8.5.1

changeset-bot · 2023-05-17T23:26:22Z

🦋 Changeset detected

Latest commit: 3e1095d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages

Name	Type
directus	Patch
@directus/app	Patch
@directus/api	Patch
docs	Patch
@directus/composables	Patch
create-directus-extension	Patch
@directus/data-driver-postgres	Patch
@directus/data	Patch
@directus/exceptions	Patch
@directus/extensions-sdk	Patch
@directus/pressure	Patch
@directus/random	Patch
@directus/release-notes-generator	Patch
@directus/storage-driver-azure	Patch
@directus/storage-driver-cloudinary	Patch
@directus/storage-driver-gcs	Patch
@directus/storage-driver-local	Patch
@directus/storage-driver-s3	Patch
@directus/storage	Patch
@directus/types	Patch
@directus/update-check	Patch
@directus/utils	Patch
tests-blackbox	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

br41nslug · 2023-05-18T07:44:51Z

@paescuj can we include an update to openapi3-ts with this patch run?

paescuj · 2023-05-18T07:56:00Z

@paescuj can we include an update to openapi3-ts with this patch run?

Will address that seperately later on this day 👍

See vitest-dev/vitest#3386

azrikahar

Aside from lints related to beforeAll not being used anymore, LGTM!

Glanced at packages with major and minor version bumps, but didn't spot anything in particular. Vitepress 1.0.0-alpha.75 did mention a breaking change for code blocks styling, but we don't really override any such styling from what I can see.

Another off-topic thing I've noticed is the pg package, where they replaced url.parse() with URL via brianc/node-postgres@f305419. Seems like we're also using url.parse() in 3 places based on a quick search, so I wonder should we opt to use URL as well (in another PR of course).

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

paescuj · 2023-05-18T11:35:46Z

Aside from lints related to beforeAll not being used anymore, LGTM!

Thanks, didn't notice them 😄 Fixed now ✅

Glanced at packages with major and minor version bumps, but didn't spot anything in particular. Vitepress 1.0.0-alpha.75 did mention a breaking change for code blocks styling, but we don't really override any such styling from what I can see.

Yes, came to the same conclusion!

Another off-topic thing I've noticed is the pg package, where they replaced url.parse() with URL via brianc/node-postgres@f305419. Seems like we're also using url.parse() in 3 places based on a quick search, so I wonder should we opt to use URL as well (in another PR of course).

Good call! ❤️ Would you like to open up a PR? 😇

azrikahar · 2023-05-18T13:40:46Z

Good call! ❤️ Would you like to open up a PR? 😇

I was looking into it, but noticed that b629bf6 actually intentionally moved away from URL in the first place to not break/error on illegal URLs. Perhaps we can make a tiny wrapper to have a default fallback base url (as I currently assume the "illegal" here is PUBLIC_URL that are not absolute) and not flat out throw an illegal url error that URL does by default.

Opting to track this on Linear for now 👍

Update directus-monorepo deps

25c21d9

paescuj added the Dependencies label May 17, 2023

paescuj added 4 commits May 18, 2023 01:41

Update @directus/api deps

2626427

Update @directus/app deps

6009ad8

Update @directus/composables deps

8937617

Update create-directus-extension deps

21d6134

paescuj force-pushed the patch-tuesday-may-23 branch from dfbfe5e to 21d6134 Compare May 18, 2023 00:05

paescuj added 2 commits May 18, 2023 02:06

Update @directus/exceptions deps

aba2209

Update @directus/data deps

829ffae

paescuj force-pushed the patch-tuesday-may-23 branch from f34f786 to 829ffae Compare May 18, 2023 00:12

paescuj added 18 commits May 18, 2023 02:15

Update @directus/data-driver-postgres deps

1b3d02d

Update @directus/extensions-sdk deps

97c9401

Update @directus/pressure deps

b6752bd

Update @directus/random deps

7979ffa

Update @directus/release-notes-generator deps

baa0335

Update @directus/storage deps

d53b070

Update @directus/storage-driver-azure deps

42c5c9a

Update @directus/storage-driver-cloudinary deps

38574f3

Update @directus/storage-driver-gcs deps

09eeb08

Update @directus/storage-driver-local deps

3d2820e

Update @directus/storage-driver-s3 deps

d280cc0

Update @directus/types deps

2a6fbc2

Update @directus/update-check deps

ced2d07

Update @directus/utils deps

d33bb1b

Update docs deps

7abaa22

Update tests-blackbox deps

c2c0091

Bump pnpm to 8.5.1

eeacd7c

Bump build-push-action in release workflow to v4

b8a2698

paescuj requested review from azrikahar, br41nslug, licitdev and rijkvanzanten May 18, 2023 08:22

paescuj marked this pull request as ready for review May 18, 2023 08:22

paescuj requested a review from phazonoverload as a code owner May 18, 2023 08:22

paescuj removed the request for review from phazonoverload May 18, 2023 08:22

Assign new spy instances before each test

1359244

See vitest-dev/vitest#3386

paescuj force-pushed the patch-tuesday-may-23 branch from c042ab0 to 1359244 Compare May 18, 2023 08:51

Create clean-needles-nail.md

479e7ea

azrikahar approved these changes May 18, 2023

View reviewed changes

Remove leftover 'beforeAll' imports

609f15b

Co-authored-by: Azri Kahar <42867097+azrikahar@users.noreply.github.com>

Merge branch 'main' into patch-tuesday-may-23

3e1095d

rijkvanzanten approved these changes May 19, 2023

View reviewed changes

br41nslug approved these changes May 19, 2023

View reviewed changes

rijkvanzanten merged commit 2e647d8 into main May 19, 2023

rijkvanzanten deleted the patch-tuesday-may-23 branch May 19, 2023 14:48

This was referenced May 19, 2023

Update Vue to 3.3.4 to satisfy '@vue/test-utils' #18658

Merged

Disable disable depreacted marked options #18685

Merged

rijkvanzanten added this to the Next Release milestone May 22, 2023

azrikahar mentioned this pull request May 25, 2023

Update openapi3-ts to v4 #18722

Merged

github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Patch Tuesday 🐸#18643

Patch Tuesday 🐸#18643
rijkvanzanten merged 29 commits intomainfrom
patch-tuesday-may-23

paescuj commented May 17, 2023 •

edited

Loading

Uh oh!

changeset-bot bot commented May 17, 2023 •

edited

Loading

Uh oh!

br41nslug commented May 18, 2023

Uh oh!

paescuj commented May 18, 2023

Uh oh!

azrikahar left a comment

Uh oh!

paescuj commented May 18, 2023

Uh oh!

azrikahar commented May 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

paescuj commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

directus-monorepo

@directus/api

❌ Can't be updated at this time

@directus/app

@directus/composables

create-directus-extension

@directus/data

❌ Can't be updated at this time

@directus/data-driver-postgres

❌ Can't be updated at this time

@directus/exceptions

@directus/extensions-sdk

@directus/pressure

@directus/random

@directus/release-notes-generator

❌ Can't be updated at this time

@directus/specs

❌ Can't be updated at this time

@directus/storage

❌ Can't be updated at this time

@directus/storage-driver-azure

@directus/storage-driver-cloudinary

@directus/storage-driver-gcs

@directus/storage-driver-local

@directus/storage-driver-s3

@directus/types

@directus/update-check

@directus/utils

docs

tests-blackbox

❌ Can't be updated at this time

Misc

Uh oh!

changeset-bot bot commented May 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

br41nslug commented May 18, 2023

Uh oh!

paescuj commented May 18, 2023

Uh oh!

azrikahar left a comment

Choose a reason for hiding this comment

Uh oh!

paescuj commented May 18, 2023

Uh oh!

azrikahar commented May 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

paescuj commented May 17, 2023 •

edited

Loading

`directus-monorepo`

`@directus/api`

`@directus/app`

`@directus/composables`

`create-directus-extension`

`@directus/data`

`@directus/data-driver-postgres`

`@directus/exceptions`

`@directus/extensions-sdk`

`@directus/pressure`

`@directus/random`

`@directus/release-notes-generator`

`@directus/specs`

`@directus/storage`

`@directus/storage-driver-azure`

`@directus/storage-driver-cloudinary`

`@directus/storage-driver-gcs`

`@directus/storage-driver-local`

`@directus/storage-driver-s3`

`@directus/types`

`@directus/update-check`

`@directus/utils`

`docs`

`tests-blackbox`

changeset-bot bot commented May 17, 2023 •

edited

Loading