Skip to content

Add formatted inline strings support#260

Merged
dilshod merged 1 commit intomasterfrom
unknown repository
Jul 31, 2023
Merged

Add formatted inline strings support#260
dilshod merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 6, 2023

There is an issue with formatted inline strings.

Cell xml:

<c s="1" t="inlineStr" r="A1">
  <is>
    <r>
      <t>Regular </t>
    </r>
    <r>
      <rPr>
        <b/>
      </rPr>
      <t>Bold</t>
    </r>
  </is>
</c>

Expected csv value: Regular Bold
Actual csv value: Regular

The proposed PR fixes this behavior.
I've added a test for this case and make sure all the other tests pass.

@dilshod dilshod merged commit c238a2d into dilshod:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant