-
Notifications
You must be signed in to change notification settings - Fork 306
Comparing changes
Open a pull request
base repository: dilshod/xlsx2csv
base: 0.8.2
head repository: dilshod/xlsx2csv
compare: 0.8.3
- 13 commits
- 4 files changed
- 5 contributors
Commits on Mar 17, 2024
-
Fix bug when missing workbook relationship
Add a check to see if the list is empty before trying to access it's contents. If an excel file has an overridden relationship with no word "book" in the name it will attempt to grab the first item of an empty list when looking up workbook relationships. IndexError: list index out of range There could be a better fix to this issue I'm not well enough versed in the xslx specification. The following xlsx file caused the issue. $ unzip -l some_file.xlsx Archive: some_file.xlsx Length Date Time Name --------- ---------- ----- ---- 142 02-06-2024 13:28 xl/worksheets/_rels/sheet1.xml.rels 65968555 02-06-2024 13:28 xl/worksheets/sheet1.xml 2078037 02-06-2024 13:28 xl/sharedStrings.xml 9867 02-06-2024 13:28 xl/styles.xml 566 02-06-2024 13:28 xl/_rels/workbook.xml.rels 388 02-06-2024 13:28 xl/workbook.xml 297 02-06-2024 13:28 _rels/.rels 1122 02-06-2024 13:28 [Content_Types].xml --------- ------- 68058974 8 files In `[Content_types].xml` it is overriding the relationships to point at `_rels/.rels` rather than `xl/_rels/workbook.xml.rels`. This causes the `workbook_relationships` list to be empty causes the error mentioned above. One can see that it does indeed have a workbook relationship, however it is being overridden. `[Contenet_types].xml`: <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types"> <Default Extension="png" ContentType="image/png"/> <Default Extension="jpeg" ContentType="image/jpeg"/> <Default Extension="rels" ContentType="application/vnd.openxmlformats-package.relationships+xml"/> <Default Extension="xml" ContentType="application/xml"/> <Default Extension="vml" ContentType="application/vnd.openxmlformats-officedocument.vmlDrawing"/> <Override PartName="/xl/worksheets/sheet1.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.worksheet+xml"/> <Override PartName="/xl/sharedStrings.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.sharedStrings+xml"/> <Override PartName="/xl/styles.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.styles+xml"/> <Override PartName="/xl/workbook.xml" ContentType="application/vnd.openxmlformats-officedocument.spreadsheetml.sheet.main+xml"/> <Override PartName="/_rels/.rels" ContentType="application/vnd.openxmlformats-package.relationships+xml"/> </Types> `xl/_rels/workbook.xml.rels`: <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"> <Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet" Target="worksheets/sheet1.xml"/> <Relationship Id="rId2" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/sharedStrings" Target="sharedStrings.xml"/> <Relationship Id="rId3" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/styles" Target="styles.xml"/> </Relationships>Configuration menu - View commit details
-
Copy full SHA for ef3ff50 - Browse repository at this point
Copy the full SHA ef3ff50View commit details
Commits on Mar 18, 2024
-
Merge pull request #277 from SeguridadRX/fix-no-workbook-relationship
Fix bug when missing workbook relationship
Configuration menu - View commit details
-
Copy full SHA for b45eb09 - Browse repository at this point
Copy the full SHA b45eb09View commit details
Commits on Apr 3, 2024
-
Update pyproject.toml with python support
Supports python 3.5-3.11 as well. See also #254
Configuration menu - View commit details
-
Copy full SHA for 3165ab3 - Browse repository at this point
Copy the full SHA 3165ab3View commit details -
Merge pull request #278 from boxydog/update_pyproject.toml
Update pyproject.toml with python support
Configuration menu - View commit details
-
Copy full SHA for d4ce8ad - Browse repository at this point
Copy the full SHA d4ce8adView commit details
Commits on Apr 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb98d88 - Browse repository at this point
Copy the full SHA cb98d88View commit details
Commits on Apr 15, 2024
-
Merge pull request #281 from alexander-beedie/fix-regex-raw-string
Fix potential `SyntaxError` when >= Python 3.12 (regex)
Configuration menu - View commit details
-
Copy full SHA for ae8db08 - Browse repository at this point
Copy the full SHA ae8db08View commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 425665d - Browse repository at this point
Copy the full SHA 425665dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1be6467 - Browse repository at this point
Copy the full SHA 1be6467View commit details -
Configuration menu - View commit details
-
Copy full SHA for b18479a - Browse repository at this point
Copy the full SHA b18479aView commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2c9f672 - Browse repository at this point
Copy the full SHA 2c9f672View commit details
Commits on Jul 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 94167aa - Browse repository at this point
Copy the full SHA 94167aaView commit details -
Merge pull request #283 from arnabanimesh/patch-1
Add Python 3.12 as supported python version in README and pyproject.toml
Configuration menu - View commit details
-
Copy full SHA for 328c26a - Browse repository at this point
Copy the full SHA 328c26aView commit details
Commits on Jul 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bed9ef1 - Browse repository at this point
Copy the full SHA bed9ef1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.8.2...0.8.3