Condition instance validation message on child condition having name#99
Merged
Condition instance validation message on child condition having name#99
Conversation
Collaborator
Author
|
Alternative to #97 that avoids hard-coding DTDL class or property names in the ParserGenerator. |
rido-min
approved these changes
Mar 23, 2023
Collaborator
rido-min
left a comment
There was a problem hiding this comment.
wondering if we need to update some test cases, and tutorials with the new validation message
Collaborator
Author
|
If this change had broken a tutorial, the PR would have failed validation, so they must be fine. Regarding tests, I suggested in #97 that you modify that PR to just be tests on top of this PR. Sound like a plan? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.