Merged
Conversation
This leads to cleaner diffs and easier code manipulation https://medium.com/@nikgraf/why-you-should-enforce-dangling-commas-for-multiline-statements-d034c98e36f8
Use Metro build config to conditionally include ICCA screens so that ICCA resouces are not included in the main Mapeo build. This avoids the images used in the ICCAs intro screens increasing the file size of the main Mapeo APK.
Choose the presets that are included in the apk at build time instead of runtime. This reduces the apk size and removes runtime code for conditionally running code based on app variant.
Adds the app variant name as an environment variable in the gradle build script so that metro bundler can package JS files according to variant by using the `sourceExts` option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt the React/Gradle build scripts so that the custom code for the Mapeo for ICCAs variant (intro screens and custom presets) is included at build time rather than run time. This means that there is no redundant data shipped in the APK of each variant (e.g. previously the general Mapeo APK also included the presets and intro screen images for Mapeo for ICCAs).
With these new build scripts it is possible to add new variants without any additional cost, other than slightly longer build times.