Closed
Conversation
React PDF has separate builds for node and the browser. Previously Webpack was not bundling any modules from node_modules, so they were being loaded by require() at runtime with Node module name resolution, so the node bundle of @react-pdf was being loaded. This change bundles all modules in node_modules in a single bundle. When bundling Webpack follows the "browser" field in package.json, so the correct build of react-pdf is bundled. The other effect of this is likely faster initial load times on machines with slow disk access, since the initial synchronous require() calls of all the many modules has a cost
This reverts commit 245949e.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rebases changes from #303 with react-mapfilter#v3 and this origin/master
All day affair.
Supersedes #303