Skip to content

Report fixes #392

Closed
okdistribute wants to merge 60 commits intomasterfrom
report-fixes-rebased
Closed

Report fixes #392
okdistribute wants to merge 60 commits intomasterfrom
report-fixes-rebased

Conversation

@okdistribute
Copy link
Copy Markdown
Contributor

@okdistribute okdistribute commented Aug 6, 2020

This rebases changes from #303 with react-mapfilter#v3 and this origin/master

All day affair.

Supersedes #303

okdistribute and others added 30 commits April 29, 2020 14:58
React PDF has separate builds for node and the browser. Previously
Webpack was not bundling any modules from node_modules, so they were
being loaded by require() at runtime with Node module name resolution,
so the node bundle of @react-pdf was being loaded.

This change bundles all modules in node_modules in a single bundle. When
bundling Webpack follows the "browser" field in package.json, so the
correct build of react-pdf is bundled. The other effect of this is likely
faster initial load times on machines with slow disk access, since the
initial synchronous require() calls of all the many modules has a cost
@okdistribute okdistribute changed the title feat: merge mapfilter into mapeo-desktopReport fixes rebased Report fixes rebased Aug 6, 2020
@okdistribute okdistribute self-assigned this Aug 6, 2020
@okdistribute okdistribute changed the title Report fixes rebased Report fixes Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants