Skip to content

Check if EditorConfig file exist for Ktlint in KotlinGradleExtension #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nedtwigg merged 1 commit into from
Nov 20, 2023
Merged

Check if EditorConfig file exist for Ktlint in KotlinGradleExtension #1889

nedtwigg merged 1 commit into from
Nov 20, 2023

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Nov 18, 2023

I missed this in #1788.

@Goooler Goooler force-pushed the check-editorconfig-exist-for-kotlin-gradle branch from fdb85bf to 2ff556b Compare November 18, 2023 17:49
@Goooler Goooler changed the title Check if EditorConfig file exist for Ktlint in KotlinGradleExtension Check if EditorConfig file exist for Ktlint in KotlinGradleExtension Nov 18, 2023
@Goooler
Copy link
Member Author

Goooler commented Nov 18, 2023

This had been finished in the Maven plugin at

spotless/plugin-maven/src/main/java/com/diffplug/spotless/maven/kotlin/Ktlint.java

Line 45 in 13a36fc

configPath = ThrowingEx.get(() -> FileSignature.signAsList(stepConfig.getFileLocator().locateFile(editorConfigPath)));

right?

@Goooler Goooler mentioned this pull request Nov 18, 2023
Merged
@nedtwigg nedtwigg merged commit d8415a5 into diffplug:main Nov 20, 2023
@nedtwigg
Copy link
Member

nedtwigg commented Nov 20, 2023

Yep, signAsList throws an error message on its own, but writing it out explicitly as you did in this PR is good too.

@Goooler Goooler deleted the check-editorconfig-exist-for-kotlin-gradle branch November 20, 2023 17:55
@nedtwigg
Copy link
Member

nedtwigg commented Nov 27, 2023

Released in plugin-gradle 6.23.0 and plugin-maven 2.41.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Goooler @nedtwigg