Add cpplint warnings for exit() and abort()#8738
Open
tautschnig wants to merge 1 commit intodiffblue:developfrom
Open
Add cpplint warnings for exit() and abort()#8738tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8738 +/- ##
===========================================
- Coverage 80.01% 80.01% -0.01%
===========================================
Files 1700 1700
Lines 188344 188345 +1
Branches 73 73
===========================================
- Hits 150701 150700 -1
- Misses 37643 37645 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ac1b378 to
3cf76d0
Compare
3cf76d0 to
21e3969
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Our code should only terminate normally via return from main, or abnormally via the macros from `invariant.h`. While at it, also fixes some warnings about cpplint.py's code. Fixes: diffblue#1902
21e3969 to
cee9fdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our code should only terminate normally via return from main, or abnormally via the macros from
invariant.h.While at it, also fixes some warnings about cpplint.py's code.
Fixes: #1902