C model library: Support ARM64 va_list types#7521
Merged
tautschnig merged 1 commit intodiffblue:developfrom Feb 7, 2023
Merged
C model library: Support ARM64 va_list types#7521tautschnig merged 1 commit intodiffblue:developfrom
tautschnig merged 1 commit intodiffblue:developfrom
Conversation
GCC/ARM appears to uses a struct to represent variadic arguments (where the first component is a pointer to the stack of arguments). Taking the pointer offset requires looking at the first element of this struct, which we do by taking the address, casting to a pointer, and dereferencing. Fixes: diffblue#7423
Codecov ReportBase: 78.50% // Head: 78.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #7521 +/- ##
========================================
Coverage 78.50% 78.50%
========================================
Files 1663 1663
Lines 191297 191297
========================================
Hits 150174 150174
Misses 41123 41123 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TGWDB
approved these changes
Feb 7, 2023
peterschrammel
approved these changes
Feb 7, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC/ARM appears to uses a struct to represent variadic arguments (where the first component is a pointer to the stack of arguments). Taking the pointer offset requires looking at the first element of this struct, which we do by taking the address, casting to a pointer, and dereferencing.
Fixes: #7423