Cover (and others) for reachable functions only#671
Merged
kroening merged 3 commits intodiffblue:masterfrom Mar 23, 2017
Merged
Cover (and others) for reachable functions only#671kroening merged 3 commits intodiffblue:masterfrom
kroening merged 3 commits intodiffblue:masterfrom
Conversation
Collaborator
|
Shouldn't it be |
Collaborator
|
I'd also prefer the terminology 'used'. The word 'reachable' really usually means 'a path exists'. Another option could be '--drop-unused-functions', which may be clearer. |
Member
Author
|
Agreed. What do we do with |
Collaborator
|
I'd say it should never have been there in the first place... I very much like your suggestion of getting rid of it. |
Collaborator
|
On Thu, 2017-03-23 at 10:45 -0700, Michael Tautschnig wrote:
I'd say it should never have been there in the first place... I very much like your suggestion of getting rid of it.
I have a vague feeling this was added as a customer request... Maybe
@kroening can remember.
|
Collaborator
|
The commit message of 22df547 doesn't answer the "why?" Just sayin'. |
1c29586 to
242af47
Compare
The default behaviour of CBMC for the options --show-goto-functions, --show-properties and --cover is to consider all functions. This is particularly annoying for --cover where coverage goals are reported from functions that are trivially unreachable from the entry point. Also, --show-reachable-properties has been introduced in the past to hide such properties. We could change the default behaviour to slicing away everything that is trivially unreachable from the entry point. However, this would require an extra option to be able to view all functions and properties. This commit preserves the default behaviour and enables focussing the output of --show-goto-functions --show-properties and --cover on functions that are not trivially unreachable using --drop-unused-functions.
The same effect can now be achieved by --show-properties --drop-unused-functions
242af47 to
5e5bbca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behaviour of CBMC for the options --show-goto-functions,
--show-properties and --cover is to consider all functions. This
is particularly annoying for --cover where coverage goals are
reported from functions that are not reachable from the entry point.
Also, --show-reachable-properties has been introduced in the past
to hide such properties.
We could change the default behaviour to slicing away everything
that is not reachable from the entry point. However, this would
require an extra option to be able to view functions and properties
that are not reachable.
This PR preserves the default behaviour and enables focussing
the output of --show-goto-functions --show-properties and --cover
on reachable functions using --reachable-functions.
The option --show-reachable-properties could be removed (including cbmc_parse_options.cpp:543-556).