Fixed test cases slice02 and slice14 from goto-instrument regression#630
Merged
kroening merged 1 commit intodiffblue:masterfrom Mar 15, 2017
Merged
Conversation
6c1602a to
83aec01
Compare
tautschnig
requested changes
Mar 14, 2017
Collaborator
tautschnig
left a comment
There was a problem hiding this comment.
I am happy with the contents of this commit, but not with the subject of the commit message as it does not tell anyone what has been changed, just the effect of which.
Invoked the full_slicer method just after generic property instrumentation so that CBMC can properly slice the program w.r.t. a given assertion in the program. Additionally, replaced returns from goto functions in goto_instrument_parse_options, as done similarly in cbmc_parse_options
83aec01 to
211cb90
Compare
Contributor
Author
|
@tautschnig: I have just updated the commit message according to your suggestion. Please let me know if you have other suggestions. As we have spoken via Skype, I'm planning to make small PRs that punctually fix the slicer regression suite. |
tautschnig
approved these changes
Mar 14, 2017
Collaborator
|
Great, thanks, approval set! |
peterschrammel
approved these changes
Mar 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoked full_slicer after generic property instrumentation so that
it can properly slice the program w.r.t. the assertion. Replaced returns
from goto functions in goto_instrument_parse_options, as done similarly
in cbmc_parse_options