Merged
Conversation
Collaborator
|
It would be nice if those edits could be committed as 3 commits as the cleanups seem rather unrelated. |
Contributor
Author
|
Can do, they're only related by the fact that I found them all while doing another piece of work. Want me to close this PR and start again? |
Member
|
@NathanJPhillips, no, just split your commit into three and force push. |
Added comment on hard to track potential error caused by #define in irep_hash This could save external users time (internal users shouldn't encounter this as we don't use Boost)
2a092f8 to
1855bcd
Compare
Contributor
Author
|
OK, done. |
tautschnig
approved these changes
Mar 14, 2017
Collaborator
tautschnig
left a comment
There was a problem hiding this comment.
Thanks for splitting up! Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added IDE files to .gitignore
Remove unnecessary casts from json.h
Added comment on hard to track potential error (it causes very cryptic messages) caused by #define in irep_hash to save external users time (internal users shouldn't encounter this as we don't use Boost)