Remove now-unused bitvector conversion exceptions#4691
Remove now-unused bitvector conversion exceptions#4691tautschnig merged 1 commit intodiffblue:developfrom
Conversation
e7e6cab to
f11e2b2
Compare
f11e2b2 to
9fa366b
Compare
thk123
left a comment
There was a problem hiding this comment.
I guess it was done in an earlier PR - this would have been easier to review I think if changes removing the throws were included too. But since this just removes apparently dead code lgtm.
| #ifdef _MSC_VER | ||
| #include <stdexcept> | ||
| // TODO(tkiley): Nested exception logging not supported on windows due to a bug | ||
| // TODO(tkiley): in MSVC++ Compiler (diffblue/cbmc#2104): |
There was a problem hiding this comment.
Add fixes #2104 to auto close the issue
9fa366b to
2d5688a
Compare
I have step-by-step removed the throws by actually implementing the cases, hence combining that into a single PR didn't seem like the best option. The more-or-less final step in getting rid of the throws was #4651. |
Byte-operator lowering no longer throws any exceptions, and thus don't need to attempt to catch them either. Remove the entire infrastructure built around these. Fixes: diffblue#2103
2d5688a to
2b4f35e
Compare
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 2b4f35e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113718309
Byte-operator lowering no longer throws any exceptions, and thus don't
need to attempt to catch them either. Remove the entire infrastructure
built around these.
Fixes: #2103