C++ function disambiguation and template scope cleanup [blocks: #1260]#2318
Merged
tautschnig merged 6 commits intodiffblue:developfrom Apr 14, 2019
Merged
Conversation
9d6ea52 to
3a86532
Compare
0bae278 to
ee8e40c
Compare
38 tasks
ee8e40c to
78b6b72
Compare
The previously added support for cpp_name (2b8ef3c) failed to insert a space after the "struct" or "union" keyword, which results in output that isn't beautiful.
This does not yet include typechecking of friend methods. Includes a fix to permit rvalue conversion to const references, which ensures unambiguous resolution for member functions.
Code cleanup and fix segmentation fault in erase-while-iterate.
78b6b72 to
aa40d59
Compare
Collaborator
Author
|
@kroening @peterschrammel This is now ready for review. |
allredj
reviewed
Apr 11, 2019
Contributor
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: aa40d59).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/108030201
peterschrammel
approved these changes
Apr 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following regression tests should also be fixed in this PR: