Move all the various id_sett typedefs into irep.h#2075
Closed
NathanJPhillips wants to merge 3 commits intodiffblue:developfrom
Closed
Move all the various id_sett typedefs into irep.h#2075NathanJPhillips wants to merge 3 commits intodiffblue:developfrom
NathanJPhillips wants to merge 3 commits intodiffblue:developfrom
Conversation
Contributor
Author
|
Test-gen bump: https://github.com/diffblue/test-gen/pull/1714 |
tautschnig
reviewed
Apr 16, 2018
Collaborator
tautschnig
left a comment
There was a problem hiding this comment.
- The cleanup seems like a good idea.
- I don't think
id_usettis a great name - can we useunordered_id_settinstead? - Any use of
id_settshould be audited: it's useful for doing set intersection/set union, but not for much else, because it won't provide the performance of a hash container and doesn't provide lexicographic ordering either (unlessirep_idt == std::string).
Contributor
|
Agreed re: |
93e8414 to
6457928
Compare
Collaborator
|
This only needs the commit messages reworded, then seems fine. |
Call them unordered_id_sett to reflect the fact that these are unordered sets
6457928 to
364b8bc
Compare
kroening
approved these changes
Apr 17, 2018
Collaborator
|
Considering #2082, I am wondering whether this actually improves readability. |
Collaborator
|
I would prefer: merge #2082 and then make good use of the commits in this PR and do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call them unordered_id_sett to reflect the fact that these are unordered sets
Add matching id_sett for signed sets of identifiers.