Skip to content

Expression transformations for symbolic execution need only be done once#150

Merged
peterschrammel merged 5 commits intodiffblue:masterfrom
tautschnig:efficient-rewrites
Feb 1, 2017
Merged

Expression transformations for symbolic execution need only be done once#150
peterschrammel merged 5 commits intodiffblue:masterfrom
tautschnig:efficient-rewrites

Conversation

@tautschnig
Copy link
Collaborator

... and should not modify expressions unnecessarily!

These should be applied once across all goto functions instead of possibly
applying them multiple times to the same source expression during symbolic
execution.

Signed-off-by: Michael Tautschnig <tautschn@amazon.com>
@martin-cs
Copy link
Collaborator

@kroening I ran into major problems caused by this issue today with a customer. Please can we have this merged to trunk?

Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@peterschrammel peterschrammel merged commit 9629f3c into diffblue:master Feb 1, 2017
@tautschnig tautschnig deleted the efficient-rewrites branch February 2, 2017 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants