Skip to content

[Bugfix] fix ldap user.getId() NPE (#1035)#1108

Merged
ZQKC merged 1 commit intodidi:masterfrom
chang-wd:master
Aug 2, 2023
Merged

[Bugfix] fix ldap user.getId() NPE (#1035)#1108
ZQKC merged 1 commit intodidi:masterfrom
chang-wd:master

Conversation

@chang-wd
Copy link
Contributor

@chang-wd chang-wd commented Aug 2, 2023

请不要在没有先创建Issue的情况下创建Pull Request。

变更的目的是什么

fix NPE issue #1035

简短的更新日志

Snipaste_2023-08-02_09-41-46

验证这一变化

NPE solved

请遵循此清单,以帮助我们快速轻松地整合您的贡献:

  • 一个 PR(Pull Request的简写)只解决一个问题,禁止一个 PR 解决多个问题;
  • 确保 PR 有对应的 Issue(通常在您开始处理之前创建),除非是书写错误之类的琐碎更改不需要 Issue ;
  • 格式化 PR 及 Commit-Log 的标题及内容,例如 [Bugfix]修复用户信息修改后,用户列表会抛出空指针异常的问题(#860) #861 。PS:Commit-Log 需要在 Git Commit 代码时进行填写,在 GitHub 上修改不了;
  • 编写足够详细的 PR 描述,以了解 PR 的作用、方式和原因;
  • 编写必要的单元测试来验证您的逻辑更正。如果提交了新功能或重大更改,请记住在 test 模块中添加 integration-test;
  • 确保编译通过,集成测试通过;

@ZQKC ZQKC added the PR: first-time contributor 第一次提交的贡献者 label Aug 2, 2023
@chang-wd chang-wd changed the title [Bugfix] fix ldap user.getId() NPE [Bugfix] fix ldap user.getId() NPE (#1035) Aug 2, 2023
@ZQKC ZQKC added this to the v3.4.0 milestone Aug 2, 2023
@ZQKC ZQKC linked an issue Aug 2, 2023 that may be closed by this pull request
1 task
@ZQKC ZQKC merged commit bdffc10 into didi:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: first-time contributor 第一次提交的贡献者

Projects

None yet

Development

Successfully merging this pull request may close these issues.

配置了ldap,登录提示调用ldap失败

2 participants