This repository was archived by the owner on Aug 23, 2019. It is now read-only.
Conversation
36 tasks
Member
|
Why create a gulp file for extra setup? The test is quite small and only runs in Node.js |
Member
Author
|
To have it run in the browser as well, or is this intended only for node usage? |
Member
|
The browser checks were not made yet. Let's not urge that, the code might need refactoring anyway. |
Member
Author
|
okay will move things to node only |
Member
Author
|
@diasdavid done |
|
Changes Unknown when pulling 8c02c85 on aegir into * on master*. |
Member
|
woooo :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@diasdavid can't get the gulp file to do the correct setup, could you take a look please?