Conversation
ccoVeille
suggested changes
Jul 19, 2024
|
|
||
| if latestVersionInDB.version > latestDBVersion { | ||
| die(`Looks like you downgraded omm. You should either delete omm's | ||
| return fmt.Errorf(`Looks like you downgraded omm. You should either delete omm's |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf(`Looks like you downgraded omm. You should either delete omm's | |
| return errors.New(`Looks like you downgraded omm. You should either delete omm's |
You are not formating here
Comment on lines
+28
to
+31
| defaultConfigDir = ".config" | ||
| defaultDataDir = ".local/share" | ||
| defaultConfigDirWindows = "AppData/Roaming" | ||
| defaultDataDirWindows = "AppData/Local" |
There was a problem hiding this comment.
|
Oh I posted my review after you merged. I started in 20 min ago 😒 |
Owner
Author
|
@ccoVeille Thanks for the review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for providing config via a TOML file.