Skip to content

feat: markdown rendering via glamour#13

Merged
dhth merged 3 commits intocompact-view-not-limited-to-nine-itemsfrom
add-glamour-based-md-rendering
Jul 22, 2024
Merged

feat: markdown rendering via glamour#13
dhth merged 3 commits intocompact-view-not-limited-to-nine-itemsfrom
add-glamour-based-md-rendering

Conversation

@dhth
Copy link
Owner

@dhth dhth commented Jul 22, 2024

Add markdown rendering for task context/details using
glamour.

Fulfils #11.

Potential follow ups

  • Markdown theme customization?
  • Fallback rendering (maybe useful for older terminal emulators, not sure)?
  • Configurable word wrapping?

@dhth dhth changed the title feat: compact view not limited to 9 items feat: markdown rendering via glamour Jul 22, 2024
@dcurgz
Copy link

dcurgz commented Jul 22, 2024

wow, what a turn around! I just tried it, and it looks great.

As a data point, I noticed the markdown syntax for completed checklists ([x]) is rendered literally, whereas glow will render this as [✓] by default. I suppose this is a theme thing?

many thanks for your efforts on this great tool!

@dhth
Copy link
Owner Author

dhth commented Jul 22, 2024

Hmm, it does render with the checklist on my computer.
This is on Alacritty:
image

And, this is on mac's native terminal.
image

Could you let me know more about your terminal emulator?

@dcurgz
Copy link

dcurgz commented Jul 22, 2024

ah, human error! I had forgotten about the hyphen required for Markdown checkboxes. Too much XIT!

changes work great (also on alacritty), thanks

@dhth
Copy link
Owner Author

dhth commented Jul 22, 2024

Awesome! 👌

Copy link

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions

@dhth dhth merged commit 81c4a61 into compact-view-not-limited-to-nine-items Jul 22, 2024
@dhth dhth deleted the add-glamour-based-md-rendering branch July 22, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants