internal/ui/help.go (1)

26-34: Fix count: header says “6 views” but lists 7 items

The header claims there are 6 views, but the list includes 7 bullet points (including Help View).

Apply this diff to correct the count:

- "hours" has 6 views:
+ "hours" has 7 views:

internal/ui/view.go (1)

281-283: Nit: minor copy tweak for consistency with help

Current text: “Press (q/<ctrl+c>/ to exit)”. Consider slightly clearer phrasing:

Apply this diff for readability:

-    Press (q/<ctrl+c>/<esc> to exit)
+    Press q/<esc> or <ctrl+c> to exit

internal/types/duration.go (2)

1-56: Add package-level docs and function comments for exported API

These functions are exported (even within internal/), so brief comments improve discoverability and editor tooling.

Proposed doc comments:

// ParseTaskLogTimes parses begin and end timestamps using timeFormat in the local timezone,
// validates the resulting duration, and returns the parsed times or a validation error.

// ValidateTaskLogDuration returns an error if end is before begin or the duration is under one minute.

---

1-56: Add focused unit tests for parsing/validation edge cases

With logic centralized here, unit tests will keep the UI tests lean and still preserve coverage across edge cases.

Here’s a starter test file you can drop in as internal/types/duration_test.go:

package types

import (
	"testing"
)

func TestGetTaskLogTimes(t *testing.T) {
	tests := []struct {
		name      string
		begin     string
		end       string
		wantErr   bool
		errSubstr string
	}{
		{"empty begin", "", "2025/08/08 00:10", true, "begin time is empty"},
		{"empty end", "2025/08/08 00:00", "", true, "end time is empty"},
		{"invalid begin", "not-a-time", "2025/08/08 00:10", true, "begin time is invalid"},
		{"invalid end", "2025/08/08 00:00", "not-a-time", true, "end time is invalid"},
		{"end before begin", "2025/08/08 01:00", "2025/08/08 00:59", true, "before begin time"},
		{"less than a minute", "2025/08/08 00:00", "2025/08/08 00:00", true, "at least a minute"},
		{"exactly one minute", "2025/08/08 00:00", "2025/08/08 00:01", false, ""},
		{"more than one minute", "2025/08/08 00:00", "2025/08/08 00:02", false, ""},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			_, _, err := GetTaskLogTimes(tt.begin, tt.end)
			if tt.wantErr && err == nil {
				t.Fatalf("expected error, got nil")
			}
			if !tt.wantErr && err != nil {
				t.Fatalf("unexpected error: %v", err)
			}
			if tt.wantErr && tt.errSubstr != "" && (err == nil || !contains(err.Error(), tt.errSubstr)) {
				t.Fatalf("error %v does not contain expected substring %q", err, tt.errSubstr)
			}
		})
	}
}

// contains is a tiny helper to avoid importing strings in the test for such a small need.
func contains(s, sub string) bool {
	return len(sub) == 0 || (len(s) >= len(sub) && indexOf(s, sub) >= 0)
}

func indexOf(s, sub string) int {
outer:
	for i := 0; i+len(sub) <= len(s); i++ {
		for j := range sub {
			if s[i+j] != sub[j] {
				continue outer
			}
		}
		return i
	}
	return -1
}

internal/ui/handle.go (1)

154-156: Likely bug: clearing the wrong input slice in editActiveTLView escape handler

You’re clearing m.taskInputs[entryBeginTS] instead of the TL input field. This likely leaves stale TL input state behind.

Replace the line with the TL input:

m.tLInputs[entryBeginTS].SetValue("")

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

internal/ui/view.go (1)

377-383: Optional: avoid float conversions when deriving seconds

Using float Seconds() then casting to int can be avoided.

Apply this minimal change:

-	totalSeconds := int(dur.Seconds())
+	totalSeconds := int(dur / time.Second)

And ensure this import exists at the top of the file:

import "time"

internal/types/duration_test.go (1)

10-118: Solid, table-driven coverage for ParseTaskLogTimes; consider a couple of cases

Current tests look good and exercise valid/invalid paths with sentinel error checks. Two optional enhancements:

• Add a success case with leading/trailing whitespace around valid times (if you decide to TrimSpace before parsing; see my suggestion on duration.go).
• Optionally assert parsed times match expected values (not just non-zero) in one or two representative cases to guard against timezone/format regressions.

If you accept trimming inputs prior to parsing, add a case like:

{
  name:     "valid times with extra whitespace",
  beginStr: "  2025/08/08 00:00 ",
  endStr:   " 2025/08/08 00:01  ",
}

internal/ui/handle.go (1)

436-446: Minor behavior check: finishing flow sets default endTS to Now() (with seconds), inputs use minute precision

This is fine functionally, but note the slight precision mismatch: inputs are minute-granular (timeFormat), while the default end timestamp here includes seconds. This can cause small deltas when users submit without editing. If you want strict minute granularity end-to-end, consider truncating Now() to minutes in this path as well.

Would you like a follow-up patch to normalize to minute precision consistently for begin/end in this flow?

internal/ui/handle.go (2)

71-74: Surface parsing/validation errors to the user instead of silently returning

Currently, errors from ParseTaskLogTimes are swallowed; the user receives no feedback.

Apply this diff:

  beginTS, endTS, err := types.ParseTaskLogTimes(m.tLInputs[entryBeginTS].Value(), m.tLInputs[entryEndTS].Value())
  if err != nil {
-		return nil
+		m.message = errMsg(fmt.Sprintf("Error: %s", err.Error()))
+		return nil
  }

---

108-111: Also surface ParseTaskLogTimes errors for create/edit TL flow

Same swallowing issue as the finish flow: user gets no feedback on invalid inputs.

Proposed fix:

  beginTS, endTS, err := types.ParseTaskLogTimes(m.tLInputs[entryBeginTS].Value(), m.tLInputs[entryEndTS].Value())
  if err != nil {
-		return nil
+		m.message = errMsg(fmt.Sprintf("Error: %s", err.Error()))
+		return nil
  }

internal/types/duration.go (1)

38-41: Inline the temporary error for brevity

A small readability improvement; no behavior change.

-	durationErr := IsTaskLogDurationValid(beginTS, endTS)
-	if durationErr != nil {
-		return zero, zero, durationErr
-	}
+	if err := IsTaskLogDurationValid(beginTS, endTS); err != nil {
+		return zero, zero, err
+	}

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting