Conversation
dhth
commented
Sep 6, 2024
- refactor: error handling
- refactor: move types to own package
- refactor: move queries.go to persistence
- test: add migration tests
refactor error handling for reports, log, stats
|
I like you are adding a lot of linters, and fix the issues. Maybe you could have split the PR in two:
It's OK, but it's a bit surprising to see them mixed. I mean it's uneasy to review the code related to the migration tests There are multiple commits, but here I'm afraid with so many changes, people might not review these specific changes. You know the meme:
BTW, I'll try to see if there are other linters you could enable |
Yeah, I agree. A split could've definitely been better. A small change snowballed into a pretty major refactor. And, yeah, the meme is definitely spot on :D |
ccoVeille
left a comment
There was a problem hiding this comment.
Good work in this refactoring.
Here are some comments
It was fun 😅 to review
|
Thanks for the reviews, @ccoVeille! |