Skip to content

refactor: add more linters#21

Merged
dhth merged 10 commits intomainfrom
add-more-linters
Sep 9, 2024
Merged

refactor: add more linters#21
dhth merged 10 commits intomainfrom
add-more-linters

Conversation

@dhth
Copy link
Owner

@dhth dhth commented Sep 6, 2024

  • refactor: error handling
  • refactor: move types to own package
  • refactor: move queries.go to persistence
  • test: add migration tests

@dhth dhth marked this pull request as draft September 6, 2024 10:48
@dhth dhth marked this pull request as ready for review September 6, 2024 12:56
@ccoVeille
Copy link

ccoVeille commented Sep 6, 2024

I like you are adding a lot of linters, and fix the issues.

Maybe you could have split the PR in two:

  • one for the linters, and their fixes
  • one for the migration tests

It's OK, but it's a bit surprising to see them mixed. I mean it's uneasy to review the code related to the migration tests

There are multiple commits, but here I'm afraid with so many changes, people might not review these specific changes.

You know the meme:

  • 50 lines changed: 100 comments
  • 5000 lines changed: LGTM 👍

BTW, I'll try to see if there are other linters you could enable

@dhth
Copy link
Owner Author

dhth commented Sep 7, 2024

I like you are adding a lot of linters, and fix the issues.

Maybe you could have split the PR in two:

  • one for the linters, and their fixes
  • one for the migration tests

It's OK, but it's a bit surprising to see them mixed. I mean it's uneasy to review the code related to the migration tests

There are multiple commits, but here I'm afraid with so many changes, people might not review these specific changes.

You know the meme:

  • 50 lines changed: 100 comments
  • 5000 lines changed: LGTM 👍

BTW, I'll try to see if there are other linters you could enable

Yeah, I agree. A split could've definitely been better. A small change snowballed into a pretty major refactor.
I'll keep that in mind for the future 👍

And, yeah, the meme is definitely spot on :D

Copy link

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work in this refactoring.

Here are some comments

It was fun 😅 to review

@dhth
Copy link
Owner Author

dhth commented Sep 9, 2024

Thanks for the reviews, @ccoVeille!

@dhth dhth merged commit 4952562 into main Sep 9, 2024
@dhth dhth deleted the add-more-linters branch September 9, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants