Conversation
internal/types/types.go
Outdated
Comment on lines
+153
to
+154
| if format != JSON && pc.ContextKey != nil { | ||
| return errSubsetKeyCannotBeUsed |
There was a problem hiding this comment.
In the validateSubsetKey function, the check erroneously verifies pc.ContextKey instead of pc.SubsetKey; this may allow invalid subset key usage when the format is not JSON. Please update the condition to check pc.SubsetKey instead.
Suggested change
| if format != JSON && pc.ContextKey != nil { | |
| return errSubsetKeyCannotBeUsed | |
| if format != JSON && pc.SubsetKey != nil { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes cueitup's interface to the following: