Skip to content

Issues #1356, #1357, #1361 and miscellaneous typo fixes in documentation#1362

Merged
Gabriella439 merged 7 commits intodhall-lang:masterfrom
winitzki:issue
Nov 20, 2023
Merged

Issues #1356, #1357, #1361 and miscellaneous typo fixes in documentation#1362
Gabriella439 merged 7 commits intodhall-lang:masterfrom
winitzki:issue

Conversation

@winitzki
Copy link
Copy Markdown
Contributor

@winitzki winitzki commented Oct 24, 2023

  • Fixing the ABNF grammar since there seems to be agreement
  • Miscellaneous typos fixed in documentation as I've been reading through it

winitzki and others added 4 commits October 24, 2023 09:59
@winitzki
Fix typo in the example about type-level List
b3c8856 
`List` goes from a type `m` to a type of `List m`, denoted in the example by `[ m ]`.
wip
89c1bd6
update changelog
0a550ff
disallow shebang in complete-expression
7a2f414
@winitzki
Copy link
Copy Markdown
Contributor Author

winitzki commented Oct 24, 2023 •
edited
Loading

I see an error Bytes occurs on the right-hand side of your grammar, but not on the left - line: 9 and I have no idea what is wrong in line 9 or in any other line.

OK I got it. Bytes in this error message refers not just to some bytes that randomly occurred in the grammar file, but to the name ("Bytes") of a new grammar rule introduced in this PR. Will fix.

Gabriella439
Gabriella439 approved these changes Nov 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small suggestion

standard/function-check.md

List

λ(m : Type) → [ m ] → m
Copy link
Copy Markdown
Contributor

@Gabriella439 Gabriella439 Nov 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking at this now, I might have meant List m instead of [ m ] (I was probably confusing Dhall with Haskell at the time I wrote this). Would it be possible to change it to use List m?

Copy link
Copy Markdown
Contributor Author

@winitzki winitzki Nov 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course, List m makes a lot more sense. Let me fix that.

@Gabriella439 Gabriella439 merged commit b82e9fb into dhall-lang:master Nov 20, 2023
@winitzki winitzki deleted the issue branch November 20, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@winitzki @Gabriella439