Allow Natural and Integer literals in binary notation#1355
Merged
Gabriella439 merged 4 commits intodhall-lang:masterfrom Nov 20, 2023
Merged
Allow Natural and Integer literals in binary notation#1355Gabriella439 merged 4 commits intodhall-lang:masterfrom
Gabriella439 merged 4 commits intodhall-lang:masterfrom
Conversation
Gabriella439
approved these changes
Oct 16, 2023
Contributor
|
I'll also help you tie the knot by merging the corresponding Haskell PR so that this will pass the |
Contributor
|
Oh wait, sorry, this can actually be fixed locally. I think you need to update the reference implementation in this repository so that the tests pass. In particular, you'll need to make a matching change here: https://github.com/dhall-lang/dhall-lang/blob/master/standard/Parser.hs |
Contributor
Author
|
Fixed. Sorry, I missed that somehow. Thank you for pointing that out. |
Contributor
|
Thank you for contributing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1215.
Haskell implementation: dhall-lang/dhall-haskell#2540.