Add to-directory-tree related definitions#1306
Add to-directory-tree related definitions#1306Gabriella439 merged 25 commits intodhall-lang:masterfrom
Conversation
5255c02 to
cf032d0
Compare
|
This is the first draft implementation of the types and functions related to the new to-directory-tree feature. Some of those are basic, some of those proved to be useful to me in my setup and for some I simply assume that they could be useful. Pinging @Gabriella439 since she proposed those additions in dhall-lang/dhall-haskell#2437 (comment). |
| @@ -0,0 +1,71 @@ | |||
| {- | @toModeWith x m@ converts some fields of a `Mask` @m@ to a `Mode`: If the | |||
There was a problem hiding this comment.
What is the motivation for the toModeWith and toAccessWith functions? Could you add some additional test cases showing some intended use cases?
There was a problem hiding this comment.
I added a motivating use case and some more examples to toModeWith. I included a pointer to that in the documentation of toAccessWith. I hope that helps?
Also added documentation for Mode/Mask/none.
Also added more examples for Mode/Mask/toModeWith.
…qual Also fixed guarded imports.
Gabriella439
left a comment
There was a problem hiding this comment.
Just one last suggestion. Otherwise, this looks good
|
@Gabriella439 I fixed the dhall-docs comments and if there is nothing else to do this PR can be merged. |
These definitions migth be helpful when one uses the fixpoint directory tree representation which got added recently to the Haskell implementation in dhall-lang/dhall-haskell#2437.